Skip to content

[Validator] Change preg_match condition on ContainsAlphanumericValidator #18972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[Validator] Change preg_match condition on ContainsAlphanumericValidator #18972

merged 1 commit into from
Oct 3, 2023

Conversation

Valmonzo
Copy link

@Valmonzo Valmonzo commented Oct 2, 2023

Hello there ! ✋🏽

I think following the Validator philosophy we prefer to check the regex this way, what do you think?

@Valmonzo Valmonzo requested a review from xabbuh as a code owner October 2, 2023 17:01
@carsonbot carsonbot added this to the 5.4 milestone Oct 2, 2023
HeahDude
HeahDude approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OskarStark
Copy link
Contributor

I like the early return 🙋‍♂️

@OskarStark OskarStark changed the title [Validator] Change preg_match condition on ContainsAlphanumericValidator [Validator] Change preg_match condition on ContainsAlphanumericValidator Oct 3, 2023
@OskarStark
Copy link
Contributor

Thank you Valmont.

@OskarStark OskarStark merged commit ab0376b into symfony:5.4 Oct 3, 2023
@Valmonzo Valmonzo deleted the 5.4 branch October 4, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Valmonzo @OskarStark @xabbuh @HeahDude @carsonbot